Closed Bug 1736796 Opened 4 years ago Closed 4 years ago

21.48 - 5.6% ts_paint_webext / sessionrestore + 10 more (Linux) regression on Sat October 16 2021

Categories

(Toolkit :: Telemetry, defect)

Product:
Toolkit
Component:
Telemetry
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox93 --- unaffected
firefox94 --- unaffected
firefox95 --- fixed

People

(Reporter: aesanu, Unassigned)

References

(Regression)

Details

(4 keywords)

Perfherder has detected a talos performance regression from push c0e719d876173a56b16e89b64ef3eb536f352467. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
21% ts_paint_webext linux1804-64-shippable-qr e10s stylo webrender-sw 278.50 -> 338.33
20% ts_paint_webext linux1804-64-shippable-qr e10s fission stylo webrender 315.92 -> 379.75
20% ts_paint linux1804-64-shippable-qr e10s stylo webrender-sw 275.75 -> 330.42
16% ts_paint_webext linux1804-64-shippable-qr e10s stylo webrender 315.79 -> 366.58
16% ts_paint linux1804-64-shippable-qr e10s stylo webrender 311.25 -> 360.25
10% startup_about_home_paint linux1804-64-shippable-qr e10s stylo webrender-sw 680.08 -> 749.00
9% startup_about_home_paint linux1804-64-shippable-qr e10s fission stylo webrender 730.08 -> 795.50
8% startup_about_home_paint linux1804-64-shippable-qr e10s stylo webrender 728.54 -> 789.67
8% startup_about_home_paint_realworld_webextensions linux1804-64-shippable-qr e10s stylo webrender 734.75 -> 794.33
7% sessionrestore_no_auto_restore linux1804-64-shippable-qr e10s stylo webrender-sw 576.08 -> 616.67
7% sessionrestore linux1804-64-shippable-qr e10s fission stylo webrender 581.04 -> 619.75
6% sessionrestore linux1804-64-shippable-qr e10s stylo webrender-sw 549.54 -> 580.33

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(bholley)

Set release status flags based on info from the regressing bug 1734262

status-firefox93: --- → unaffected
status-firefox94: --- → unaffected
status-firefox-esr78: --- → unaffected
status-firefox-esr91: --- → unaffected

Seems like the pushlog [1] also contained bug 1736068, which seems much more likely to be the culprit here. The regressions here are both very large and also linux-only, and it would be weird for a cross-platform change to cause that. Moreover, bug 1736068 specifically changes the linux widget code for displaying native windows, which is exactly what all these talos tests are measuring.

[1] https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3417336ac329d16885da04dbde931933e980d2c1&tochange=20bebe9b0129b66ac814330deb5bf7d1d8aabcdc

Flags: needinfo?(bholley) → needinfo?(aesanu)

Hm, no — I see it now [1].

This seems likely related to bug 1736189, which is an uptick in crashes on the same tests.

[1] https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=talos%2Clinux&tochange=20bebe9b0129b66ac814330deb5bf7d1d8aabcdc&fromchange=8b4ea97211d7b333d6fe9d9a6a7db3cec23e736d&selectedTaskRun=QuQJafWUTwyR0eQ-GHg-xQ.0

Flags: needinfo?(aesanu) → needinfo?(bholley)

We switch back to the old pingsender in bug 1736373, and the regression reversion was reported in bug 1736373 comment 40.

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox95: affected → fixed
Resolution: --- → FIXED

I filed bug 1746983 to track the reenabling.

Flags: needinfo?(bholley)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.